Skip to content

Commit

Permalink
fix: do not ship broken symlinks in webkit for mac (microsoft#5512)
Browse files Browse the repository at this point in the history
Since we don't ship things like WebKitPluginAgent, we can
safely remove all the symlinks that point to the missing targets.

Fixes microsoft#5472
  • Loading branch information
aslushnikov authored Feb 20, 2021
1 parent 496aeeb commit eb3efb3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 2 additions & 2 deletions browser_patches/webkit/BUILD_NUMBER
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
1437
Changed: dgozman@gmail.com Fri Feb 19 16:12:07 PST 2021
1438
Changed: lushnikov@chromium.com Fri Feb 19 21:08:07 PST 2021
3 changes: 3 additions & 0 deletions browser_patches/webkit/archive.sh
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ createZipForMac() {
# copy protocol
node $SCRIPTS_DIR/concat_protocol.js > $tmpdir/protocol.json

# Remove all broken symlinks. @see https://github.com/microsoft/playwright/issues/5472
find "${tmpdir}" -type l ! -exec test -e {} \; -print | xargs rm

# zip resulting directory and cleanup TMP.
ditto -c -k $tmpdir $ZIP_PATH
rm -rf $tmpdir
Expand Down

0 comments on commit eb3efb3

Please sign in to comment.