Skip to content

Commit

Permalink
Default channel to GA is not specified otherwise (oamg#1205)
Browse files Browse the repository at this point in the history
Originally we tried to map by default repositories from particular channels on the source system to their equivalents on the target system. IOW:

    * eus -> eus
    * aus -> aus
    * e4s -> e4s
    * "ga" -> "ga"
    ...

However, it has been revealed this logic should not apply on minor releases for which these non-ga (premium) repositories do not exist. So doing upgrade e.g. to 8.9, 8.10 , 9.3 for which specific eus, etc.. repositories are not defined lead to 404 error.

Discussing this deeply between stakeholders, it has been decided to drop this logic and target always to "ga" repositories unless the leapp is executed with instructions to choose a different channel (using envars, --channel .. option). To prevent this issue.

It's still possible to require mistakenly e.g. "eus" channel for the target release for which the related repositories are not defined. e.g.:
     > leapp upgrade --channel eus --target 8.10

In such a case, the previous errors (404 Not found) can be hit again. But it will not happen by default. In this case, we expect and request people to understand what they want when they use the option.

@pirat89 : Updated commit msg

jira: RHEL-24720
(cherry picked from commit a4e3906)
  • Loading branch information
matejmatuska authored and yuravk committed Aug 20, 2024
1 parent 17bc2cb commit 3e7d49a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions commands/upgrade/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ def prepare_configuration(args):

if args.channel:
os.environ['LEAPP_TARGET_PRODUCT_CHANNEL'] = args.channel
elif 'LEAPP_TARGET_PRODUCT_CHANNEL' not in os.environ:
os.environ['LEAPP_TARGET_PRODUCT_CHANNEL'] = 'ga'

if args.iso:
os.environ['LEAPP_TARGET_ISO'] = args.iso
Expand Down

0 comments on commit 3e7d49a

Please sign in to comment.