forked from apache/gravitino
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[apache#596] feat(hive): Hive catalog supports to impersonate users t…
…o execute operations in simple mode. (apache#1450) ### What changes were proposed in this pull request? Hive catalog supports to impersonate users to execute operations in simple mode. For Kerberos mode, I have created an new issue. I will finish it in the later pull request. We use a Hive client cache pool referring to the Iceberg cache pool. We use user name as the key of cache pool. ### Why are the changes needed? Fix: apache#596 ### Does this PR introduce _any_ user-facing change? Yes, we will add a new document. ### How was this patch tested? Add a new IT --------- Co-authored-by: Heng Qin <qqtt@123.com>
- Loading branch information
Showing
19 changed files
with
712 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
140 changes: 140 additions & 0 deletions
140
...gs/catalog-hive/src/main/java/com/datastrato/gravitino/catalog/hive/CachedClientPool.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,140 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package com.datastrato.gravitino.catalog.hive; | ||
|
|
||
| import com.datastrato.gravitino.utils.ClientPool; | ||
| import com.github.benmanes.caffeine.cache.Cache; | ||
| import com.github.benmanes.caffeine.cache.Caffeine; | ||
| import com.github.benmanes.caffeine.cache.Scheduler; | ||
| import com.google.common.annotations.VisibleForTesting; | ||
| import com.google.common.collect.Lists; | ||
| import com.google.common.util.concurrent.ThreadFactoryBuilder; | ||
| import java.io.IOException; | ||
| import java.io.UncheckedIOException; | ||
| import java.util.List; | ||
| import java.util.concurrent.ScheduledThreadPoolExecutor; | ||
| import java.util.concurrent.ThreadFactory; | ||
| import java.util.concurrent.TimeUnit; | ||
| import javax.annotation.Nullable; | ||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.hive.metastore.IMetaStoreClient; | ||
| import org.apache.hadoop.security.UserGroupInformation; | ||
| import org.apache.thrift.TException; | ||
| import org.immutables.value.Value; | ||
|
|
||
| /** | ||
| * Referred from Apache Iceberg's CachedClientPool implementation | ||
| * hive-metastore/src/main/java/org/apache/iceberg/hive/CachedClientPool.java | ||
| * | ||
| * <p>ClientPoolCache is used for every HiveCatalog, I changed the type of `clientPoolCache` from | ||
| * static variable to variable. I change cache key from user and configuration options to the | ||
| * username. | ||
| * | ||
| * <p>A ClientPool that caches the underlying HiveClientPool instances. | ||
| */ | ||
| public class CachedClientPool implements ClientPool<IMetaStoreClient, TException> { | ||
|
|
||
| private final Cache<Key, HiveClientPool> clientPoolCache; | ||
|
|
||
| private final Configuration conf; | ||
| private final int clientPoolSize; | ||
|
|
||
| CachedClientPool(int clientPoolSize, Configuration conf, long evictionInterval) { | ||
| this.conf = conf; | ||
| this.clientPoolSize = clientPoolSize; | ||
| // Since Caffeine does not ensure that removalListener will be involved after expiration | ||
| // We use a scheduler with one thread to clean up expired clients. | ||
| this.clientPoolCache = | ||
| Caffeine.newBuilder() | ||
| .expireAfterAccess(evictionInterval, TimeUnit.MILLISECONDS) | ||
| .removalListener((ignored, value, cause) -> ((HiveClientPool) value).close()) | ||
| .scheduler( | ||
| Scheduler.forScheduledExecutorService( | ||
| new ScheduledThreadPoolExecutor(1, newDaemonThreadFactory()))) | ||
| .build(); | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| HiveClientPool clientPool() { | ||
| Key key = extractKey(); | ||
| return clientPoolCache.get(key, k -> new HiveClientPool(clientPoolSize, conf)); | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| Cache<Key, HiveClientPool> clientPoolCache() { | ||
| return clientPoolCache; | ||
| } | ||
|
|
||
| @Override | ||
| public <R> R run(Action<R, IMetaStoreClient, TException> action) | ||
| throws TException, InterruptedException { | ||
| return clientPool().run(action); | ||
| } | ||
|
|
||
| @Override | ||
| public <R> R run(Action<R, IMetaStoreClient, TException> action, boolean retry) | ||
| throws TException, InterruptedException { | ||
| return clientPool().run(action, retry); | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| static Key extractKey() { | ||
| List<Object> elements = Lists.newArrayList(); | ||
| try { | ||
| elements.add(UserGroupInformation.getCurrentUser().getUserName()); | ||
| } catch (IOException e) { | ||
| throw new UncheckedIOException(e); | ||
| } | ||
|
|
||
| return Key.of(elements); | ||
| } | ||
|
|
||
| @Value.Immutable | ||
| abstract static class Key { | ||
|
|
||
| abstract List<Object> elements(); | ||
|
|
||
| private static Key of(Iterable<?> elements) { | ||
| return ImmutableKey.builder().elements(elements).build(); | ||
| } | ||
| } | ||
|
|
||
| @Value.Immutable | ||
| abstract static class ConfElement { | ||
| abstract String key(); | ||
|
|
||
| @Nullable | ||
| abstract String value(); | ||
|
|
||
| static ConfElement of(String key, String value) { | ||
| return ImmutableConfElement.builder().key(key).value(value).build(); | ||
| } | ||
| } | ||
|
|
||
| private static ThreadFactory newDaemonThreadFactory() { | ||
| return new ThreadFactoryBuilder() | ||
| .setDaemon(true) | ||
| .setNameFormat("hive-metastore-cleaner" + "-%d") | ||
| .build(); | ||
| } | ||
|
|
||
| public void close() { | ||
| clientPoolCache.invalidateAll(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.