Skip to content

Misc: Django 5.2 update #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Misc: Django 5.2 update #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/tox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,22 +62,24 @@ jobs:
matrix:
python: ["3.8", "3.9", "3.10", "3.11", "3.12"]
# build LTS version, next version, HEAD
django: ["32", "42", "50", "main"]
django: ["42", "50", "52", "main"]
exclude:
- python: "3.8"
django: "50"
- python: "3.8"
django: "52"
- python: "3.8"
django: "main"
- python: "3.9"
django: "50"
- python: "3.9"
django: "52"
- python: "3.9"
django: "main"
- python: "3.10"
django: "main"
- python: "3.11"
django: "32"
- python: "3.12"
django: "32"
django: "main"

env:
TOXENV: django${{ matrix.django }}-py${{ matrix.python }}
Expand Down
4 changes: 4 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ repos:
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix]
name: ruff (fix)
- id: ruff
args: [--select=ALL]
name: ruff (check)

# python static type checking
- repo: https://github.com/pre-commit/mirrors-mypy
Expand Down
8 changes: 5 additions & 3 deletions .ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
line-length = 88

[lint]
ignore = [
"D100", # Missing docstring in public module
"D101", # Missing docstring in public class
Expand Down Expand Up @@ -34,13 +36,13 @@ select = [
"W", # pycodestype (warnings)
]

[isort]
[lint.isort]
combine-as-imports = true

[mccabe]
[lint.mccabe]
max-complexity = 8

[per-file-ignores]
[lint.per-file-ignores]
"*tests/*" = [
"D205", # 1 blank line required between summary line and description
"D400", # First line should end with a period
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

All notable changes to this project will be documented in this file.

## v0.4

* Add Django 5.2 to build matrix
* Drop support for Django versions before 4.2
* Update ruff commands to use modern "ruff check" syntax
* Update GitHub Actions to only test Django main branch with Python 3.12

## v0.3

* Add Django 5.0 to build matrix
Expand Down
6 changes: 6 additions & 0 deletions README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

Django management command for monitoring file diffs.

## Compatibility

Supports:
- Django 4.2, 5.0, 5.2
- Python 3.8 to 3.12 (depending on Django version)

## Background

With a large codebase, and a high velocity team making edits, it can be
Expand Down
3 changes: 2 additions & 1 deletion project_checks/management/commands/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ def print_contents(self, contents: list[str]) -> None:
"""Dump the contents to stdout."""
if contents:
self.stdout.write("--- Contents ---")
self.stdout.writelines(contents)
Copy link
Author

@thmsrmbld thmsrmbld May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses an issue where tests were failing in Django 5.2 due to a change in output handling. In previous Django versions, writelines() would implicitly add newlines between elements. But Django 5.2 aligns with Python's standard behavior where it doesn't. Fixed by explicitly adding newlines when outputting content in the print_contents() method of DiffCheckCommand, ensuring consistent behavior across all supported Django versions and keeping the test passing.

for line in contents:
self.stdout.write(line + "\n")
else:
self.stdout.write("No contents found.")
self.stdout.write("")
Expand Down
8 changes: 3 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "django-project-checks"
version = "0.3"
version = "0.4"
description = "Django management commands used to output useful project information."
license = "MIT"
authors = ["YunoJuno <code@yunojuno.com>"]
Expand All @@ -12,11 +12,9 @@ documentation = "https://github.com/yunojuno/poetry-template"
classifiers = [
"Environment :: Web Environment",
"Framework :: Django",
"Framework :: Django :: 3.2",
"Framework :: Django :: 4.0",
"Framework :: Django :: 4.1",
"Framework :: Django :: 4.2",
"Framework :: Django :: 5.0",
"Framework :: Django :: 5.2",
"License :: OSI Approved :: MIT License",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3 :: Only",
Expand All @@ -30,7 +28,7 @@ packages = [{ include = "project_checks" }]

[tool.poetry.dependencies]
python = "^3.8"
django = "^3.2 || ^4.0 || ^5.0"
django = "^4.2 || ^5.0"

[tool.poetry.dev-dependencies]
black = "*"
Expand Down
14 changes: 5 additions & 9 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,20 @@ envlist =
fmt, lint, mypy,
django-checks,
; https://docs.djangoproject.com/en/5.0/releases/
django32-py{38,39,310}
django40-py{38,39,310}
django41-py{38,39,310,311}
django42-py{38,39,310,311}
django50-py{310,311,312}
djangomain-py{311,312}
django52-py{310,311,312}
djangomain-py312

[testenv]
deps =
coverage
pytest
pytest-cov
pytest-django
django32: Django>=3.2,<3.3
django40: Django>=4.0,<4.1
django41: Django>=4.1,<4.2
django42: Django>=4.2,<4.3
django50: https://github.com/django/django/archive/stable/5.0.x.tar.gz
django50: Django>=5.0,<5.1
django52: https://github.com/django/django/archive/stable/5.2.x.tar.gz
djangomain: https://github.com/django/django/archive/main.tar.gz

commands =
Expand All @@ -48,7 +44,7 @@ deps =
ruff

commands =
ruff project_checks
ruff check project_checks

[testenv:mypy]
description = Python source code type hints (mypy)
Expand Down