add externalTrafficPolicy feature support for service #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiangzii
force-pushed
the
master
branch
3 times, most recently
from
40f97f8
to
d97e6ae
Compare
qiangzii
force-pushed
the
master
branch
8 times, most recently
from
440586e
to
29e947b
Compare
cumirror
reviewed
Aug 22, 2022
docs/configure.md
Outdated
|
|
||
|
|
||
| `Cluster`模式下，目前支持的 `service` 注解有： | ||
| - 使用指定Label的Worker节点作为后端服务器， `service.beta.kubernetes.io/qingcloud-lb-backend-label`，可以指定多个Label，多个Label以逗号分隔。例如：`key1=value1,key2=value2`，多个Label之间是And关系 |
There was a problem hiding this comment.
这里对svc的注解做了说明和示例，需要添加node上的label说明和示例，并描述svc label里多个kv时的匹配策略。
| return nil, true, nil | ||
| } | ||
|
|
||
| // producer |
| cnc.nodeQueue.Add(key) | ||
| } | ||
|
|
||
| // consumer |
|
|
||
| const ( | ||
| clusterNodeSyncPeriod = 30 * time.Second | ||
| clusterNodeWorkers = 10 |
There was a problem hiding this comment.
10个线程是否有点多，一般是1个或3个。如果worker中有任务会等待较长时间则需要注意。
| return true | ||
| } | ||
|
|
||
| for newLabelKey, newLabelValue := range new.Labels { |
There was a problem hiding this comment.
这里的判断是否更细一些：判断 service.beta.kubernetes.io/qingcloud-lb-backend-label 的变化。
| return nil, true, nil | ||
| } | ||
|
|
||
| // producer |
There was a problem hiding this comment.
这里的一些注释，意见和nodecluster部分一样。
pkg/qingcloud/qingcloud.go
Outdated
| @@ -189,6 +194,17 @@ func (qc *QingCloud) getLoadBalancer(service *v1.Service) (*LoadBalancerConfig, | |||
| func (qc *QingCloud) EnsureLoadBalancer(ctx context.Context, _ string, service *v1.Service, nodes []*v1.Node) (*v1.LoadBalancerStatus, error) { | |||
| conf, lb, err := qc.getLoadBalancer(service) | |||
| klog.V(4).Infof("==== EnsureLoadBalancer %s config %s ====", spew.Sdump(lb), spew.Sdump(conf)) | |||
| if err != nil { | |||
There was a problem hiding this comment.
这里在后续考虑lb找不到的场景 errors.IsResourceNotFound(err)。所以要提前退出时，可以判断是否是 errors.IsResourceNotFound(err) 的场景。
pkg/qingcloud/qingcloud.go
Outdated
| } | ||
|
|
||
| if len(toAdd) == 0 && len(toDelete) == 0 && modify == false { | ||
| klog.Infof("Skip UpdateLB for loadbalancers %s", *lb.Status.LoadBalancerID) | ||
| //update backend; for enample, service annotation for backend label changed |
qiangzii
force-pushed
the
master
branch
2 times, most recently
from
b1f07cc
to
c2f6c04
Compare
add backend label support for service; add endpoint controller and cluster node controller; Signed-off-by: gangqiangwang <gangqiangwang@yunify.com>;
cumirror
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gangqiangwang gangqiangwang@yunify.com;