Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: danger #13

Merged
merged 3 commits into from
Dec 4, 2023
Merged

feat: danger #13

merged 3 commits into from
Dec 4, 2023
+239 −24

Conversation

novr
Copy link
Member

@novr novr commented Nov 22, 2023 •
edited
Loading

main

  • feat: danger & swiftlint

without

  • fix swiftlint waring

@novr novr self-assigned this Nov 22, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited
Loading

Messages
📖

Good Job 💮

Feature PR Check

Checking Item Result
Base Branch Check 🎉
Merge Commit Non-Existence Check 🎉
Diff Volume Check 🎉

Generated by 🚫 Danger Swift against d4e295a

@novr novr force-pushed the feature/danger branch 2 times, most recently from 8e494ca to 8fedb3d Compare November 24, 2023 04:53
@novr novr added the enhancement New feature or request label Nov 24, 2023
@novr novr marked this pull request as ready for review November 24, 2023 05:53
@novr novr requested a review from a team November 24, 2023 05:53
ykws
ykws approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@ykws ykws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Danger/Package.swift Outdated Show resolved Hide resolved
@novr @ykws
Update Danger/Package.swift
d4e295a 
Co-authored-by: KAWASHIMA Yoshiyuki <ykawashi7@gmail.com>
@novr novr merged commit 2fea28c into main Dec 4, 2023
2 checks passed
@novr novr deleted the feature/danger branch December 4, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykws ykws ykws approved these changes

Assignees

@novr novr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novr @ykws