Skip to content

Conversation

@vain0x
Copy link
Contributor

@vain0x vain0x commented Aug 6, 2024

This PR fixes the issue that inserted path contains \ (backslash) instead of / on Windows.

For example:

// latest (v0.3.2)
import * as AnotherLogics from "./logics\AnotherLogics";

// fixed
import * as AnotherLogics from "./logics/AnotherLogics";

Copy link
Owner

@yukukotani yukukotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I believe you can just replace path.relative by path.posix.relative instead of manipulating string. Could you try it?

@vain0x
Copy link
Contributor Author

vain0x commented Aug 6, 2024

Thanks! I changed the PR.

Copy link
Owner

@yukukotani yukukotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yukukotani yukukotani merged commit f86eb2a into yukukotani:master Aug 6, 2024
@yukukotani
Copy link
Owner

Released in https://github.com/yukukotani/typescript-plugin-namespace-import/releases/tag/v0.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants