Skip to content

Commit

Permalink
[chore](fe) update aspectj-maven-plugin to 1.14.0 version (apache#17890)
Browse files Browse the repository at this point in the history
In apache#17797 , we introduced aspectj to help log exception easily.
However, the plugin version 1.11 do not support jdk9 and later.
For support compile FE with jdk11

update aspectj-maven-plugin to 1.14.0 version
add new dependency org.aspectj.aspectjrt 1.9.7 to fe-core
according to:

aspectj java version compatibility
aspectj-maven-plugin issue
aspectj release note
intro to aspectj
  • Loading branch information
morrySnow authored Mar 19, 2023
1 parent dd53bc1 commit 295b26d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
7 changes: 6 additions & 1 deletion fe/fe-common/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,12 @@ under the License.
<dependency>
<groupId>org.aspectj</groupId>
<artifactId>aspectjweaver</artifactId>
<version>1.8.13</version>
<version>${aspectj.version}</version>
</dependency>
<dependency>
<groupId>org.aspectj</groupId>
<artifactId>aspectjrt</artifactId>
<version>${aspectj.version}</version>
</dependency>
</dependencies>
<build>
Expand Down
2 changes: 1 addition & 1 deletion fe/fe-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ under the License.
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>aspectj-maven-plugin</artifactId>
<version>1.11</version>
<version>1.14.0</version>
<executions>
<execution>
<phase>process-classes</phase>
Expand Down
1 change: 1 addition & 0 deletions fe/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ under the License.
<maven.compiler.target>1.8</maven.compiler.target>
<sonar.organization>apache</sonar.organization>
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
<aspectj.version>1.9.7</aspectj.version>
<cglib.version>2.2</cglib.version>
<commons-cli.version>1.4</commons-cli.version>
<commons-filerupload.version>1.5</commons-filerupload.version>
Expand Down

0 comments on commit 295b26d

Please sign in to comment.