-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0%
steps in @keyframe animations incorrectly changed to 0
#80
Comments
Would @keyframe anim{0%{opacity:0}100%{opacity:1}} be equivalent? |
@tml Yeah that would work perfectly. |
Your fix only resolves @Keyframes, however, remember that there are many others such as: @-moz-keyframes This will work better: css = css.replaceAll("(@(?:-.+?)?keyframe.*?)0{", "$10%{"); |
👍 Thanks, @Bigwebmaster; I didn't consider vendor-specific extensions. |
It is also stripping "deg" unit from "0deg". /*! Before minification */
} /*! After minification */ |
I have just downgraded to the previous version that didn't have this bug. |
+1 @leods92 - this issue breaks the following css rule at mobile webkit browsers |
The pull requests here don't solve the issue. It works if you have 0% { ........ } but fails if there is a comma, Ex: @-webkit-keyframes circlebounce {
0%, 100% { -webkit-transform: scale(0.0) }
50% { -webkit-transform: scale(1.0) }
} |
still a forked yui required http://cl.ly/Udo9
Does using |
Solved by using 0.00% instead 0% |
@snusmubrik thanks! |
I can't make sense somebody fix this bug? |
@Gennady77 This should be fixed if you use master. |
I use npm chanel and there is latest version and there is the bug. |
I don't know anything about how npm is choosing to bundle this, maybe you can reach out to them and ask them to join in the conversation here? |
@tml I just built form master, same result. |
you can use "from" - "to" instead of 0%- 100% |
+1 on the from and to for now |
0.00% instead of 0% fixed this problem for me. Thanks! |
Use 00% instead of 0% |
Should be fixed in master (see #231) |
I'm affected for the same.
|
same here, just ran into the issue trying to minify the spectre css files which have the following code:
using yuicompressor 2.4.8 |
I was able to fix this issue by doing the following:
This prevents 0%/100% from having the "%" removed, as well as the "deg" being removed. These issues really should be fixed. I shouldn't have to fight with a minifier. This minifier has also been officially adopted by PHPWebstorm (which I use for work). The minifier was installed using NPM via command-line. NPM's version should be verified to be using the MASTER version so fixes of this nature are included. |
The previously workaround do work, but they are working. Using CSS animations librairies is a nightmare, because you have to rewrite every-rules. |
Taking the following CSS:
The output will be incorrectly rewritten to:
This is not functionally equivalent.
The text was updated successfully, but these errors were encountered: