Ignore docs changes for yb-ctl GH action #7388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSignal
changed the title
polarweasel
suggested changes
Feb 26, 2021
There was a problem hiding this comment.
In order to test that the ignore is working, I suggest making a change to docs/content/latest/admin/yb-ctl.md to make sure it doesn't trigger the CTL checks.
Deleting line 18 (one of two blank lines in a row) would be a great change, since it should be deleted anyway. :)
polarweasel
reviewed
Jun 4, 2021
polarweasel
reviewed
Jun 4, 2021
polarweasel
reviewed
Jun 4, 2021
Can't have both a paths and a paths-ignore entry. Changing to negative syntax for the docs path to be ignored.
polarweasel
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
This looks good to me, but I made the last change here, so @iSignal please take a look and merge if it's good with you?
|
looks good, thanks for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yb-ctl workflow was being run for updates to the docs pages for it.