Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Simplify grammar and diagrams generation for API docs #2069

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

m-iancu
Copy link
Contributor

@m-iancu m-iancu commented Aug 15, 2019

Grammar and diagrams for API docs can now be generated automatically by running a script.
Also they are now shown in tabs (as alternative representations of the syntax) rather
than on after the other.
The docs Readme is updated with instructions on how to edit/update the docs with
this new set-up.

The YSQL docs are updated to use the new framework, the YCQL ones are not yet changed.
Also a few other minor fixes in the YSQL docs.

@yugabyte-ci
Copy link
Contributor

Can one of the admins verify this patch?

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2019

CLA assistant check
All committers have signed the CLA.

docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@stevebang stevebang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc updates needed as commented.

@m-iancu m-iancu force-pushed the docs_gram branch 4 times, most recently from 2ad521b to 2bc5ec3 Compare August 19, 2019 20:11
Summary:

Grammar and diagrams for API docs can now be generated automatically by running a script.
Also they are now shown in tabs (as alternative representations of the syntax) rather
than on after the other.
The docs Readme is updated with instructions on how to edit/update the docs with
this new set-up.

The YSQL docs are updated to use the new framework, the YCQL ones are not yet changed.
Also a few other minor fixes in the YSQL docs.

Test Plan: None

Reviewers: karthik, sid, steve, neha

Subscribers: yql
Copy link
Contributor

@stevebang stevebang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much improved. :-)

@m-iancu
Copy link
Contributor Author

m-iancu commented Aug 19, 2019

How it should look:

Grammar Tab (Default):

image

Diagram Tab:

image

@schoudhury schoudhury merged commit e7b7a2b into yugabyte:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants