Fix shellcheck warnings and lower the required CMake version #15195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbautin
commented
Dec 1, 2022
•
mbautin
commented
- Fix shellcheck warnings in run-test.sh and yb_build.sh.
- Change required CMake version to 3.17.3.
|
second commit seems to have un-did the first commit? |
mbautin
force-pushed
the
fix_shellcheck
branch
from
63a601e to
c9ecf6b
Compare
mbautin
changed the title
mbautin
changed the title
mbautin
changed the title
svarnau
approved these changes
Dec 1, 2022
jayant07-yb
pushed a commit
to jayant07-yb/yugabyte-db
that referenced
this pull request
Dec 7, 2022
…e#15195) - Fix shellcheck warnings in run-test.sh and yb_build.sh. - Change required CMake version to 3.17.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.