Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update core-db contribute docs #14729

Merged
merged 8 commits into from
Oct 31, 2022

Conversation

jasonyb
Copy link
Contributor

@jasonyb jasonyb commented Oct 28, 2022

Fix some outdated portions of core-db contribute docs. There are other
outdated portions remaining, like the recommended OS changing from
centos to alma and the default compiler changing from gcc to clang, but
leave that change to the build team.

Also fix some typos/grammar.

@jasonyb jasonyb added the area/documentation Documentation needed label Oct 28, 2022
@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for infallible-bardeen-164bc9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit aec4064
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/63601aaac56d1100094293e6
😎 Deploy Preview https://deploy-preview-14729--infallible-bardeen-164bc9.netlify.app/preview/contribute/core-database/run-unit-tests
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@ddorian ddorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for Alex's review too.

Copy link
Contributor

@polarweasel polarweasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor changes, then merge this one. :)

Co-authored-by: Alex Ball <aball@yugabyte.com>
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2022

CLA assistant check
All committers have signed the CLA.

@jasonyb jasonyb merged commit 5f6cb8c into yugabyte:master Oct 31, 2022
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this pull request Dec 7, 2022
Fix some outdated portions of core-db contribute docs. There are other
outdated portions remaining, like the recommended OS changing from
centos to alma and the default compiler changing from gcc to clang, but
leave that change to the build team.

Also fix some typos/grammar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants