-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update core-db contribute docs #14729
Conversation
✅ Deploy Preview for infallible-bardeen-164bc9 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please wait for Alex's review too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Minor changes, then merge this one. :)
docs/content/preview/contribute/core-database/run-unit-tests.md
Outdated
Show resolved
Hide resolved
docs/content/preview/contribute/core-database/run-unit-tests.md
Outdated
Show resolved
Hide resolved
docs/content/preview/contribute/core-database/run-unit-tests.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Ball <aball@yugabyte.com>
Co-authored-by: Alex Ball <aball@yugabyte.com>
Co-authored-by: Alex Ball <aball@yugabyte.com>
Fix some outdated portions of core-db contribute docs. There are other outdated portions remaining, like the recommended OS changing from centos to alma and the default compiler changing from gcc to clang, but leave that change to the build team. Also fix some typos/grammar.
Fix some outdated portions of core-db contribute docs. There are other
outdated portions remaining, like the recommended OS changing from
centos to alma and the default compiler changing from gcc to clang, but
leave that change to the build team.
Also fix some typos/grammar.