Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] Use google style import rules #9344

Open
sb-yb opened this issue Jul 16, 2021 · 0 comments
Open

[Platform] Use google style import rules #9344

sb-yb opened this issue Jul 16, 2021 · 0 comments
Assignees
@sb-yb
Labels
area/platform Yugabyte Platform

Comments

@sb-yb
Copy link
Contributor

sb-yb commented Jul 16, 2021

Dont use wildcard imports and use google style for import ordering
@SergeyPotachev SergeyPotachev added the area/platform Yugabyte Platform label Jul 19, 2021
sb-yb added a commit that referenced this issue Jul 19, 2021
@sb-yb
[#9344] google style import ordering
c31097a 
Summary:
Dont use wildcard imports and use google style for import ordering
Using
https://raw.githubusercontent.com/google/styleguide/gh-pages/intellij-java-google-style.xml
schema and changing only import ordering.
For rest of the formatting we should continue to use sbt javafmtAll

Test Plan: N/A

Reviewers: arnav, spotachev, jvigil

Reviewed By: spotachev, jvigil

Subscribers: jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D12291
sb-yb added a commit that referenced this issue Jul 19, 2021
@sb-yb
[#9344] test folder - google style imports formatting
925f01c 
Summary: Missed formatting unit tests in last diff.

Test Plan: N/A

Reviewers: spotachev, jvigil

Reviewed By: jvigil

Subscribers: yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D12303
sb-yb added a commit that referenced this issue Jul 19, 2021
@sb-yb
[#9344] Exclude formatting changes from blame
3ff2934 
Summary: Update .git-ignore-blame file so thatr formatting changes are ignorred from git bame

Test Plan: N/A

Reviewers: jvigil

Reviewed By: jvigil

Subscribers: yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D12304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sb-yb sb-yb

Labels
area/platform Yugabyte Platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SergeyPotachev @sb-yb