Skip to content

[YSQL] Nodes crash due to spaces in g-flag values during universe creation or g-flag upgrades #25006

Open
@shishir2001-yb

Description

Jira Link: DB-14149

Description

Version: 2.25.0.0 and any version before it

If a universe is created or g-flags are upgraded, and spaces are unintentionally included between two values of a g-flag, the nodes may crash with the following core dump. Ideally, this should be handled internally to prevent such issues.

The allowed_preview_flags_csv is provided here as an example, but this behavior could affect several other g-flags as well:

"allowed_preview_flags_csv":"ysql_yb_enable_ash, ysql_yb_ash_enable_infra"

                                                ^(This space)         
* thread #1, name = 'yb-tserver', stop reason = signal SIGABRT
  * frame #0: 0x00007f461ab40acf libc.so.6`raise + 271
    frame #1: 0x00007f461ab13ea5 libc.so.6`abort + 295
    frame #2: 0x0000558e50c058c9 yb-tserver`google::logging_fail() + 9
    frame #3: 0x0000558e50c055f4 yb-tserver`google::LogMessage::SendToLog() + 2612
    frame #4: 0x0000558e50c05cfd yb-tserver`google::LogMessage::Flush() + 221
    frame #5: 0x0000558e50c06349 yb-tserver`google::LogMessageFatal::~LogMessageFatal() + 9
    frame #6: 0x0000558e52775b1a yb-tserver`yb::ParseCommandLineFlags(argc=<unavailable>, argv=<unavailable>, remove_flags=true) at flags.cc:623:7
    frame #7: 0x0000558e5236abc8 yb-tserver`yb::MasterTServerParseFlagsAndInit(server_type="tserver", is_master=<unavailable>, argc=0x00007ffec4c1d5d0, argv=0x00007ffec4c1d2b8) at server_main_util.cc:146:3
    frame #8: 0x0000558e524ccbe8 yb-tserver`yb::tserver::TabletServerMain(argc=<unavailable>, argv=<unavailable>) at tablet_server_main_impl.cc:253:3
    frame #9: 0x0000558e50bb5154 yb-tserver`main(argc=3, argv=0x00007ffec4c1e518) at master_main.cc:184:12
    frame #10: 0x00007f461ab2cd85 libc.so.6`__libc_start_main + 229
    frame #11: 0x0000558e50a7c02e yb-tserver`_start + 46



Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions