Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] ASH: Ignore Ash calls #22465

Closed
1 task done
amitanandaiyer opened this issue May 21, 2024 · 1 comment
Closed
1 task done

[DocDB] ASH: Ignore Ash calls #22465

amitanandaiyer opened this issue May 21, 2024 · 1 comment
Assignees
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@amitanandaiyer
Copy link
Contributor

amitanandaiyer commented May 21, 2024

Jira Link: DB-11382

Description

After https://phorge.dev.yugabyte.com/rYBDBde9fd5d5d43eb2afa34701bb951c3e3fd0fde7c8 ash calls seem to be included.

This is a regression and needs to be fixed.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@amitanandaiyer amitanandaiyer added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels May 21, 2024
@amitanandaiyer amitanandaiyer self-assigned this May 21, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels May 21, 2024
amitanandaiyer added a commit that referenced this issue May 22, 2024
Summary:
Due to a refactor in de9fd5d  ActiveSessionHistory calls seem to include the ASH calls while fetching samples from the TServer, even if `ignore_ash_and_perform_calls` is set.

This diff fixes the regression.
Jira: DB-11382

Test Plan: wait_states-itest

Reviewers: asaha

Reviewed By: asaha

Subscribers: ybase, yql

Differential Revision: https://phorge.dev.yugabyte.com/D35227
svarnau pushed a commit that referenced this issue May 25, 2024
Summary:
Due to a refactor in de9fd5d  ActiveSessionHistory calls seem to include the ASH calls while fetching samples from the TServer, even if `ignore_ash_and_perform_calls` is set.

This diff fixes the regression.
Jira: DB-11382

Test Plan: wait_states-itest

Reviewers: asaha

Reviewed By: asaha

Subscribers: ybase, yql

Differential Revision: https://phorge.dev.yugabyte.com/D35227
@rthallamko3 rthallamko3 removed the status/awaiting-triage Issue awaiting triage label Jun 11, 2024
@rthallamko3
Copy link
Contributor

@amitanandaiyer , Do you plan to backport this to 2024.1 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants