Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] [ASH] Classify wait states as CPU, Disk, IO and locks #21594

Closed
1 task done
hbhanawat opened this issue Mar 20, 2024 · 0 comments
Closed
1 task done

[DocDB] [ASH] Classify wait states as CPU, Disk, IO and locks #21594

hbhanawat opened this issue Mar 20, 2024 · 0 comments
Assignees
@amitanandaiyer
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@hbhanawat
Copy link
Contributor

hbhanawat commented Mar 20, 2024 •
edited by jira bot
Loading

Jira Link: DB-10483

Description

This will help to do the aggregation of the events based on the system bottlenecks

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@hbhanawat hbhanawat added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Mar 20, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Mar 20, 2024
@hbhanawat hbhanawat removed the status/awaiting-triage Issue awaiting triage label Mar 20, 2024
amitanandaiyer added a commit that referenced this issue Apr 2, 2024
@amitanandaiyer
[#21594] Ash: Classify docdb wait-states into CPU/Disk/IO and Locks
5b05364 
Summary:
Implement GetWaitStateType(WaitStateCode code) to classify wait states to highlight
the main resource that the rpc waits in a given state.

Note that since we have only chosen to create a wait state for large enough waits,
we may have wait states that use multiple of the resources eg cpu/locks or cpu/disk etc.
We mark such states based on the expected resource which the state is use the most.
Jira: DB-10483

Test Plan: yb_build.sh --cxx-test wait_states-itest

Reviewers: asaha, hbhanawat

Reviewed By: asaha

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D33650
amitanandaiyer added a commit that referenced this issue Apr 4, 2024
@amitanandaiyer
[BACKPORT 2024.1][#21594] Ash: Classify docdb wait-states into CPU/Di…
bc4a860 
…sk/IO and Locks

Summary:
Original commit: 5b05364 / D33650
Implement GetWaitStateType(WaitStateCode code) to classify wait states to highlight
the main resource that the rpc waits in a given state.

Note that since we have only chosen to create a wait state for large enough waits,
we may have wait states that use multiple of the resources eg cpu/locks or cpu/disk etc.
We mark such states based on the expected resource which the state is use the most.
Jira: DB-10483

Test Plan: yb_build.sh --cxx-test wait_states-itest

Reviewers: asaha, hbhanawat

Reviewed By: asaha

Subscribers: ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D33807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amitanandaiyer amitanandaiyer

Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hbhanawat @yugabyte-ci @amitanandaiyer