[YSQL] Table rewrite operations are unsafe #19860
Assignees
Labels
Comments
fizaaluthra
added
area/ysql
yugabyte-ci
added
kind/bug
myang2021
added a commit
that referenced
this issue
Jun 24, 2024
…t output Summary: The unit test org.yb.pgsql.TestPgRegressIndex.testPgRegressIndex is always failing now because the test output needs to be updated due to a recently introduced table rewrite NOTICE output: ``` NOTICE: table rewrite may lead to inconsistencies DETAIL: Concurrent DMLs may not be reflected in the new table. HINT: See #19860. Set 'ysql_suppress_unsafe_alter_notice' yb-tserver gflag to true to suppress this notice. ``` In addition, the test output itself isn't reliable because of the following error for statement `drop index idxpart0_pkey;`: ``` ERROR: cannot drop index idxpart0_pkey because index idxpart_pkey requires it HINT: You can drop index idxpart_pkey instead. ``` vs ``` ERROR: cannot drop index idxpart0_pkey because constraint idxpart0_pkey on table idxpart0 requires it HINT: You can drop constraint idxpart0_pkey on table idxpart0 instead. ``` Both are possible and which one gets reported depends upon the order in the pg_depend scan output. Because pg_depend does not have a primary key, it uses YB generated uuid and therefore the scan output order isn't fixed. I updated the expected test output. Jira: DB-5819 Test Plan: ./yb_build.sh release --java-test 'org.yb.pgsql.TestPgRegressIndex#testPgRegressIndex' Reviewers: fizaa Reviewed By: fizaa Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D36068
myang2021
added a commit
that referenced
this issue
Jun 27, 2024
…ndex expected test output Summary: The unit test org.yb.pgsql.TestPgRegressIndex.testPgRegressIndex is always failing now because the test output needs to be updated due to a recently introduced table rewrite NOTICE output: ``` NOTICE: table rewrite may lead to inconsistencies DETAIL: Concurrent DMLs may not be reflected in the new table. HINT: See #19860. Set 'ysql_suppress_unsafe_alter_notice' yb-tserver gflag to true to suppress this notice. ``` In addition, the test output itself isn't reliable because of the following error for statement `drop index idxpart0_pkey;`: ``` ERROR: cannot drop index idxpart0_pkey because index idxpart_pkey requires it HINT: You can drop index idxpart_pkey instead. ``` vs ``` ERROR: cannot drop index idxpart0_pkey because constraint idxpart0_pkey on table idxpart0 requires it HINT: You can drop constraint idxpart0_pkey on table idxpart0 instead. ``` Both are possible and which one gets reported depends upon the order in the pg_depend scan output. Because pg_depend does not have a primary key, it uses YB generated uuid and therefore the scan output order isn't fixed. I updated the expected test output. Jira: DB-5819 Original commit: e69dc27 / D36068 Test Plan: ./yb_build.sh release --java-test 'org.yb.pgsql.TestPgRegressIndex#testPgRegressIndex' Reviewers: fizaa Reviewed By: fizaa Subscribers: yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D36210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-8804
Description
Currently in YB table rewrite operations (like ALTER TYPE, ADD/DROP primary key) are unsafe, i.e., concurrent writes may not be reflected in the new table.
Issue Type
kind/bug
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: