Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Clearly separate type-checked vs. non-type checked Python scripts #17268

Open
1 task done
mbautin opened this issue May 10, 2023 · 0 comments
Open
1 task done

[DocDB] Clearly separate type-checked vs. non-type checked Python scripts #17268

mbautin opened this issue May 10, 2023 · 0 comments
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@mbautin
Copy link
Contributor

mbautin commented May 10, 2023 •
edited by jira bot
Loading

Jira Link: DB-6502

Description

This will remove the need to constantly add entries to codecheck.ini.

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@mbautin mbautin added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels May 10, 2023
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels May 10, 2023
mbautin added a commit that referenced this issue May 10, 2023
@mbautin
[#17268] Consolidate type-checked Python-based build scripts into the…
9d99f77 
… python/yugabyte directory

Summary:
Consolidate Python-based build scripts from python/yb and build-support into the python/yugabyte directory. This simplifies the codecheck.ini file: we don't have to list all the files where we need to check types, we just put it in that directory. As part of this, adding type annotations and fixing a few related errors in some of the scripts that were not previously type-checked.

Also, when these Python scripts are invoked from Bash scripts, we are now using intermediate variables named YB_SCRIPT_PATH_..., which are set in common-build-env.sh and the existence of the corresponding paths is checked in common-build-env-test.sh.

Test Plan: Jenkins

Reviewers: steve.varnau, hsunder

Reviewed By: steve.varnau, hsunder

Subscribers: jenkins-bot, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D25188
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature and removed kind/bug This issue is a bug status/awaiting-triage Issue awaiting triage labels May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbautin @yugabyte-ci