Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DocDB] Add build time checks to make sure AutoFlags for master and tserver are generated #14633

Closed
hari90 opened this issue Oct 24, 2022 · 0 comments
Closed

[DocDB] Add build time checks to make sure AutoFlags for master and tserver are generated #14633

hari90 opened this issue Oct 24, 2022 · 0 comments
Assignees
@hari90
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@hari90
Copy link
Contributor

hari90 commented Oct 24, 2022 •
edited by yugabyte-ci
Loading

Jira Link: DB-4003

Description

The LTO build recently broke AutoFlags as the process names changed causing the AutoFlags json to have a wrong string name. We need build time safety to protect against such issues.
@hari90 hari90 added kind/enhancement This is an enhancement of an existing feature area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Oct 24, 2022
@hari90 hari90 self-assigned this Oct 24, 2022
@yugabyte-ci yugabyte-ci added priority/medium Medium priority issue and removed status/awaiting-triage Issue awaiting triage labels Oct 24, 2022
@hari90 hari90 closed this as completed in bb29627 Nov 7, 2022
jayant07-yb pushed a commit to jayant07-yb/yugabyte-db that referenced this issue Dec 7, 2022
@hari90
[yugabyte#14633,yugabyte#13474] DocDB: Add build time protection to p…
940d1d9 
…revent AutoFlags that have shipped from being removed

Summary:
Once a AutoFlag is added to the code and shipped to customers it cannot be removed. Even before this change, we make sure previously promoted AutoFlags still exist at process startup time, so if we accidentally remove it then it will cause the upgrade to fail.
Now adding `previous_auto_flags.json` file to the repo which contains the AutoFlags from the previous release. At build time we make sure this is a subset of the current set of AutoFlags.
`build-support/stabilize_auto_flags_list.py` is used to update `previous_auto_flags.json` file regularly by the release managers. It will be run every time the version number is bumped. This script runs a build with `--skip-java` flag to produce the current `auto_flags.json` and copies its contents over to `previous_auto_flags.json`.

Fixes yugabyte#14633
Fixes yugabyte#13474

Test Plan:
./build-support/stabilize_auto_flags_list.py
./yb_build.sh

Reviewers: steve.varnau, mbautin

Reviewed By: steve.varnau, mbautin

Subscribers: zyu, jenkins-bot, bogdan, ybase, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D20649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hari90 hari90

Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hari90 @yugabyte-ci