[Phase 1][YSQL][Colocation] Get rid of tablegroup_oid reloption #12719
Assignees
Labels
area/ysql
Yugabyte SQL (YSQL)
kind/enhancement
This is an enhancement of an existing feature
priority/medium
Medium priority issue
Comments
frozenspider
added
kind/enhancement
yugabyte-ci
added
kind/bug
frozenspider
added a commit
that referenced
this issue
Jun 17, 2022
Summary: Previously, `YBCPgTableProperties` were fetched on demand from the tserver and transparently cached as a part of `PgApiImpl::GetTableDesc`. This has been reworked to be a lazily loaded part of `Relation` struct, and is thus now cached explicitly. Note that cache invalidation (e.g. because of `catalog_version` change, or `CommandCounterIncrement`) naturally discards this field which is a desired behaviour most of the time. I've added a TODO note of how should we optimize `Relation` creation, but since fetching `yb_table_properties` is hitting `PgTableDesc` cache most of the time, this is low-pri. Since YB table properties are now accessible to PG directly, `YbIsUserTableColocated` was removed. I decided to extract this into a separate diff while working on #12719 as I think this is a self-sufficient chunk of work that feels like a strict improvement over the way things were done before. Test Plan: Existing tests. Also, manually tested that all places where this is used still work as before. Reviewers: jason, dmitry, tverona, mihnea, myang Reviewed By: myang Subscribers: yql Differential Revision: https://phabricator.dev.yugabyte.com/D17692
frozenspider
added
kind/enhancement
yugabyte-ci
added
kind/bug
frozenspider
added a commit
that referenced
this issue
Jun 29, 2022
Summary: At the time prior to this diff, `tablegroup_oid` remained the only YB-specifc property that we store in `reloptions` rather than in YB-specific struct. Since master is always aware of the tablegroup, moved this to be exclusive to `YbTableProperties` and to be fetched from master. One side effect of this change is that table's primary key is no longer shown as belonging to the tablegroup (since PK is a dummy thing in YB). Discussed this to be okay (and we can tweak this later if needed). Test Plan: Existing tests Reviewers: myang, tverona, mihnea, dmitry, jason Reviewed By: jason Subscribers: yql, bogdan Differential Revision: https://phabricator.dev.yugabyte.com/D17779
yugabyte-ci
changed the title
yugabyte-ci
added
kind/enhancement
yugabyte-ci
changed the title
frozenspider
added a commit
that referenced
this issue
Jul 1, 2022
Summary: This is a follow-up to 5e23584 / D17692 and f363a09 / D17779 that does some minor refactoring/cleanup discussed for those diffs. Two style changes are: * Removed `OptTableGroup` grammar node, replaced with a plain `char *` tablegroup name. * Replaced `YbLoadTablePropertiesIfNeeded` with a more traditional lazy loading getter. There are no functional changes. Test Plan: Existing tests Reviewers: jason, dmitry Reviewed By: dmitry Subscribers: yql Differential Revision: https://phabricator.dev.yugabyte.com/D17997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-607
Description
Right now,
tablegroup_oidis the only YB-speicifc option we store in reloptions rather than in YB-specific struct. There's little reason for that.The text was updated successfully, but these errors were encountered: