Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[#12293] YSQL: Use better defaults for copy command
Summary: With AsyncFlush landed in master (D16005), we adjust the default values to achieve a better copy performance. Note that we cannot set ROWS PER TRANSACTION too high as it will OOM the tserver; once packed column is enabled, we will set it at higher value (see D16717). Note that if one sets ROWS PER TRANSACTION too high, we get the error: ``` ysqlsh:/home/centos/gen_table/insert_script.sql:6: ERROR: Remote error: Service unavailable (yb/rpc/yb_rpc.cc:165): Call rejected due to memory pressure: Call yb.tserver.PgClientService.Perform 172.151.28.7:54138 => 172.151.28.7:9100 (request call id 2301) ``` Test Plan: jenkins Run and test on portal (make sure to disable packed column): On copying 1M rows with 2 CPUs: ``` 512 ysql_session_max_batch_size, 20K rows per transaction: 01:50.504 3072 ysql_session_max_batch_size, 20K rows per transaction: 01:45.250 ``` Reviewers: smishra, rthallam Reviewed By: rthallam Subscribers: yql Differential Revision: https://phabricator.dev.yugabyte.com/D16752
- Loading branch information