-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PLAT-12440] Fixed the 'switch to correct branch' step of update-vers…
…ion GH action Summary: - The update-version GH action of the charts repo has an issue for 2.20.* releases. It was switching to the 2.2 branch for the 2.20 releases in the 'switch to correct branch' step because 2.20 is treated as a number and gets truncated to 2.2 as the simplest form. - I made the changes to pass the 'yb_release_train' argument as a string. - It will fix the following GH action failures - - https://github.com/yugabyte/charts/actions/runs/7559369603/job/20583030779 - https://github.com/yugabyte/charts/actions/runs/7659484788/job/20874696519 Test Plan: - Tested it on custom gh action - https://github.com/baba230896/test-helm-versioning/actions/runs/7692835435 - curl command ``` curl -X POST \ -H "Authorization: token TOKEN" \ -H "Accept: application/vnd.github.everest-preview+json" \ -H "Content-Type: application/json" https://api.github.com/repos/baba230896/test-helm-versioning/dispatches \ --data '{"event_type": "update-on-release", "client_payload": {"yb_release_train_f": 2.20, "yb_release_train_str": "2.20" } }' ``` Reviewers: bgandhi, sanketh, anijhawan, jharveysmith Reviewed By: bgandhi Differential Revision: https://phorge.dev.yugabyte.com/D32003
- Loading branch information
1 parent
d5df8e6
commit 8f8b810
Showing
1 changed file
with
18 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters