Skip to content

Commit

Permalink
Fix restore failures due to incorrect IP usage
Browse files Browse the repository at this point in the history
Summary:
A recent revert of the code also inadvertently caused a necessary piece of code to get
changed, causing failures to restores in case of dual NIC clusters.
Culprit PR: D15306

Test Plan: Create a dual NIC cluster, create a backup, restore a backup. Also run an itest.

Reviewers: daniel

Reviewed By: daniel

Subscribers: yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D15798
  • Loading branch information
Arnav15 committed Mar 3, 2022
1 parent 26ce40e commit 6b6fe11
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions managed/devops/bin/yb_backup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2917,6 +2917,8 @@ def find_tablet_replicas(self, snapshot_metadata):
if LEADING_UUID_RE.match(line):
(ts_uuid, ts_ip_port, role) = split_by_tab(line)
(ts_ip, ts_port) = ts_ip_port.split(':')
if self.ts_secondary_to_primary_ip_map:
ts_ip = self.ts_secondary_to_primary_ip_map[ts_ip]
tablets_by_tserver_ip.setdefault(ts_ip, set()).add(new_id)

return tablets_by_tserver_ip
Expand Down

0 comments on commit 6b6fe11

Please sign in to comment.