Reporting the GIST / BRIN / SPGIST index methods in analyze-schema using pg-parser and also adding them in assessment report #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reporting them in assessment
makalaaneesh
reviewed
Oct 8, 2024
| @@ -41,6 +29,18 @@ OPTIONS ( | |||
| table_name 't' | |||
| ); | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
why did this move down, suddenly?
There was a problem hiding this comment.
as we are now putting the ALTER FOREIGN TABLE in foreign_table.sql at the end. it will fail after the CREATE FOREIGN TABLE now. so order of that in this file matters.
There was a problem hiding this comment.
Okay, but the filename still says table.sql below?
There was a problem hiding this comment.
yeah, I didn't change it as we ignore the file name while validating these files I just moved it as is.
There was a problem hiding this comment.
oh what do we use it for then?!
There was a problem hiding this comment.
I think it's just there, and the file path can vary that's why it's not getting validated. cc: @shubham-yb
makalaaneesh
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description-
ALTER FOREIGN TABLEfor Default constraint case inforeign_table.sql. https://yugabyte.atlassian.net/browse/DB-12734Jenkins:
https://jenkins.dev.yugabyte.com/job/users/job/yb-voyager-testing/job/yb-voyager-testing-pipeline/3631/
https://jenkins.dev.yugabyte.com/job/users/job/yb-voyager-testing/job/yb-voyager-testing-pipeline/3633/