Added new workloads to update 10k/50k rows to existing microbenchmark updateG1_varying_rows.yaml #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalsagarwal
requested changes
Dec 13, 2024
| - workload: update_50000 | ||
| run: | ||
| - name: update_1000_rows |
There was a problem hiding this comment.
- names for the workload are same, please update them.
| - workload: update_50000_hash_table | ||
| run: | ||
| - name: update_1000_rows |
There was a problem hiding this comment.
names for the workload are same, please update them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current microbenchmarks only updates max 1k rows. Considering the variations we have seen between test it is important to have tests with higher row count like 10-50k. As mentioned by Mark Peacock, these scenarios are seen in production.
So wrote new microbenchmarks queries and triggered a validation runs on master and Yusong’s private build
https://perf.dev.yugabyte.com/dashboard/output/8468702
https://perf.dev.yugabyte.com/dashboard/output/8468602