fix(settings): Add missing err handlers on settings_register

yuanbin · Dec 15, 2020 · ae63ce5 · ae63ce5
1 parent 2204a5d
commit ae63ce5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/app/src/ext_power_generic.c b/app/src/ext_power_generic.c
@@ -142,7 +142,12 @@ static int ext_power_generic_init(const struct device *dev) {
 #if IS_ENABLED(CONFIG_SETTINGS)
     settings_subsys_init();
 
-    settings_register(&ext_power_conf);
+    int err = settings_register(&ext_power_conf);
+    if (err) {
+        LOG_ERR("Failed to register the ext_power settings handler (err %d)", err);
+        return err;
+    }
+
     k_delayed_work_init(&ext_power_save_work, ext_power_save_state_work);
 
     // Set default value (on) if settings isn't set

diff --git a/app/src/rgb_underglow.c b/app/src/rgb_underglow.c
@@ -267,7 +267,12 @@ static int zmk_rgb_underglow_init(const struct device *_arg) {
 #if IS_ENABLED(CONFIG_SETTINGS)
     settings_subsys_init();
 
-    settings_register(&rgb_conf);
+    int err = settings_register(&rgb_conf);
+    if (err) {
+        LOG_ERR("Failed to register the ext_power settings handler (err %d)", err);
+        return err;
+    }
+
     k_delayed_work_init(&underglow_save_work, zmk_rgb_underglow_save_state_work);
 
     settings_load_subtree("rgb/underglow");