refactor(app): replace zmk_mod with zmk_mod_t

Aligns with typedef _t convention. PR: zmkfirmware#531
yuanbin · Dec 28, 2020 · 05b0d18 · 05b0d18
1 parent 8717969
commit 05b0d18
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/app/include/zmk/hid.h b/app/include/zmk/hid.h
@@ -166,8 +166,8 @@ struct zmk_hid_consumer_report {
     struct zmk_hid_consumer_report_body body;
 } __packed;
 
-int zmk_hid_register_mod(zmk_mod modifier);
-int zmk_hid_unregister_mod(zmk_mod modifier);
+int zmk_hid_register_mod(zmk_mod_t modifier);
+int zmk_hid_unregister_mod(zmk_mod_t modifier);
 int zmk_hid_implicit_modifiers_press(zmk_mod_flags implicit_modifiers);
 int zmk_hid_implicit_modifiers_release();
 int zmk_hid_keyboard_press(zmk_key_t key);

diff --git a/app/include/zmk/keys.h b/app/include/zmk/keys.h
@@ -10,7 +10,7 @@
 #include <dt-bindings/zmk/keys.h>
 
 typedef uint32_t zmk_key_t;
-typedef uint8_t zmk_mod;
+typedef uint8_t zmk_mod_t;
 typedef uint8_t zmk_mod_flags;
 
 struct zmk_key_event {

diff --git a/app/src/hid.c b/app/src/hid.c
@@ -26,15 +26,15 @@ static zmk_mod_flags explicit_modifiers = 0;
         LOG_DBG("Modifiers set to 0x%02X", keyboard_report.body.modifiers);                        \
     }
 
-int zmk_hid_register_mod(zmk_mod modifier) {
+int zmk_hid_register_mod(zmk_mod_t modifier) {
     explicit_modifier_counts[modifier]++;
     LOG_DBG("Modifier %d count %d", modifier, explicit_modifier_counts[modifier]);
     WRITE_BIT(explicit_modifiers, modifier, true);
     SET_MODIFIERS(explicit_modifiers);
     return 0;
 }
 
-int zmk_hid_unregister_mod(zmk_mod modifier) {
+int zmk_hid_unregister_mod(zmk_mod_t modifier) {
     if (explicit_modifier_counts[modifier] <= 0) {
         LOG_ERR("Tried to unregister modifier %d too often", modifier);
         return -EINVAL;