Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Youtube] Avoid crashing if n-sig decode fails #30585

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

dirkf
Copy link
Contributor

@dirkf dirkf commented Feb 1, 2022

Please follow the guide below


Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

When JSInterp-based n-parameter decoding was implemented to replace the temporary fix from derived from VLC, the descrambling code acquired a try block that re-raised any exception during descrambling as an ExtractorError. This caused yt-dl to fail if the decoding failed, whereas the program could have continued with a warning and run the download at the throttled rate.

This PR changes the re-raised exception to a warning. The warning may be shown as many times as the n-parameter is found in the item's media URLs, but that should be an incentive to patch the program quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant