[servus] change to site new url and update api url #29556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
changed the title
|
Will/Can this be merged? I confirm the fix working fine. |
ghost
mentioned this pull request
|
Tried to test your PR with https://www.servustv.com/volkskultur/v/aawg5x4ywdc94xyjv9ly/, got |
crea-doo
reviewed
Dec 15, 2021
youtube_dl/extractor/servus.py
Outdated
| @@ -18,30 +18,35 @@ class ServusIE(InfoExtractor): | |||
| (?:www\.)? | |||
| (?: | |||
| servus\.com/(?:(?:at|de)/p/[^/]+|tv/videos)| | |||
| (?:servustv|pm-wissen)\.com/videos | |||
| (?:servustv|pm-wissen)\.com/(?:videos|[^/]+/v) | |||
| ) | |||
| /(?P<id>[aA]{2}-\w+|\d+-\d+) | |||
There was a problem hiding this comment.
When adding a additional |\w+ for the id then also id's without a separator will work like the mentioned https://www.servustv.com/volkskultur/v/aawg5x4ywdc94xyjv9ly/
The full line should then be: /(?P<id>[aA]{2}-\w+|\d+-\d+|\w+)
There was a problem hiding this comment.
I was away and couldn't notice your review.
|
Updated video-id regex. |
|
I tested with your branch, too, and works again. Great! |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Resolves #29485, resolves #29554, resolves #29825, resolves #30493.
Change to ServusTV new url (first commit) and update api url (second commit).
Note:
If anyone tries this PR, be sure to apply all the changes. Otherwise you won't get the expected results.