Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README.md] change video id that looks like a typo #29398

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[README.md] change video id that looks like a typo #29398

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 26, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Example video id BaW_jenozKcj in README.md seems to be a typo of BaW_jenozKc.

Though there doesn't occur an error using in URL https://www.youtube.com/watch?v=BaW_jenozKcj, I happened to use only BaW_jenozKcj, I got error below and confused.

ERROR: 'BaW_jenozKcj' is not a valid URL. Set --default-search "ytsearch" (or run  youtube-dl "ytsearch:BaW_jenozKcj" ) to search YouTube

@pukkandan
Copy link
Contributor

pukkandan commented Jun 26, 2021

The typo seems to exist in CONTRIBUTING.md and in the issue_templates as well

@ghost
Copy link
Author

ghost commented Jun 26, 2021

CONTRIBUTING.md should be generated from README.md.

youtube-dl/Makefile

Lines 78 to 79 in 379f52a

CONTRIBUTING.md: README.md
$(PYTHON) devscripts/make_contributing.py README.md CONTRIBUTING.md

I guess I misunderstood ISSUE_TEMPLATEs are also generated from README.md. Added ISSUE_TEMPLATE_tmpl. Thanks.
I left http: unchanged, as they are handled by youtube-dl or redirected by browsers.

pukkandan added a commit to yt-dlp/yt-dlp that referenced this pull request Jul 3, 2021
Lesmiscore added a commit to ytdl-patched/ytdl-patched that referenced this pull request Jul 6, 2021
* 'master' of https://github.com/yt-dlp/yt-dlp:
  [cleanup] Fix linter and some typos Related: ytdl-org/youtube-dl#29398
  [videa] Fix extraction (#463)
nixxo pushed a commit to nixxo/yt-dlp that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants