-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADN] Implement login #27937
[ADN] Implement login #27937
Conversation
3610430
to
313537a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extraction should not stop if login process fails.
Thanks for the fix, really appreciate it! |
Download now works fine with --username --password ✅ but subtittle decrypt doesnt work ❌ Edit subs works fine on "free videos" edit 2 : Its workings fine xd, made a mistake in my cmd script 😄 |
You sure? I think if I provide login credentials but they are wrong I wouldn't expect extraction to silently continue, given that not being logged in might mean lower quality. |
not silently, there would be a warning. |
Hmm … I think I'd rather have people remove their login credentials if there's a problem but I can also agree with a warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an account is needed to check the code locally.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Closes #27841.