Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADN] Implement login #27937

Merged
merged 1 commit into from
Jan 25, 2021
Merged

[ADN] Implement login #27937

merged 1 commit into from
Jan 25, 2021

Conversation

adrianheine
Copy link
Contributor

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Closes #27841.

youtube_dl/extractor/adn.py Outdated Show resolved Hide resolved
youtube_dl/extractor/adn.py Outdated Show resolved Hide resolved
@adrianheine adrianheine force-pushed the adn branch 2 times, most recently from 3610430 to 313537a Compare January 24, 2021 09:18
Copy link
Collaborator

@remitamine remitamine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extraction should not stop if login process fails.

youtube_dl/extractor/adn.py Outdated Show resolved Hide resolved
@MrTechyyy
Copy link

Thanks for the fix, really appreciate it!

@Azzuray
Copy link

Azzuray commented Jan 24, 2021

Download now works fine with --username --password ✅ but subtittle decrypt doesnt work ❌

Edit subs works fine on "free videos"

edit 2 : Its workings fine xd, made a mistake in my cmd script 😄

@adrianheine
Copy link
Contributor Author

extraction should not stop if login process fails.

You sure? I think if I provide login credentials but they are wrong I wouldn't expect extraction to silently continue, given that not being logged in might mean lower quality.

@remitamine
Copy link
Collaborator

extraction should not stop if login process fails.

You sure? I think if I provide login credentials but they are wrong I wouldn't expect extraction to silently continue, given that not being logged in might mean lower quality.

not silently, there would be a warning.

@adrianheine
Copy link
Contributor Author

Hmm … I think I'd rather have people remove their login credentials if there's a problem but I can also agree with a warning.

Copy link
Collaborator

@remitamine remitamine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an account is needed to check the code locally.

youtube_dl/extractor/adn.py Outdated Show resolved Hide resolved
@remitamine remitamine merged commit ea399a5 into ytdl-org:master Jan 25, 2021
ThirumalaiK pushed a commit to ThirumalaiK/youtube-dl that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADN] Can't download premium video after extractor fix
4 participants