[reddit] try_get larger thumbnail images with fallback #27503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozburo
changed the title
ozburo
changed the title
|
Extract all resolutions. |
|
You mean extract all the available images into a |
|
Yes, much nicer xD |
dstftw
requested changes
Dec 26, 2020
| images = try_get( | ||
| data, lambda x: x['preview']['images'][0]['resolutions']) or [] | ||
| for image in images: | ||
| url = url_or_none(unescapeHTML(image['url'])) |
Comment on lines
+130
to
+131
| 'width': int_or_none(image['width']), | ||
| 'height': int_or_none(image['height']), |
| thumbnails = [] | ||
| images = try_get( | ||
| data, lambda x: x['preview']['images'][0]['resolutions']) or [] | ||
| for image in images: |
There was a problem hiding this comment.
Breaks if ...['resolutions'] is not a list.
| @@ -9,6 +9,7 @@ | |||
| float_or_none, | |||
| try_get, | |||
| url_or_none, | |||
| unescapeHTML, | |||
ThirumalaiK
pushed a commit
to ThirumalaiK/youtube-dl
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
The current RedditRIE extractor simply returns the root thumb url for thumbnails, which is very small. This improvement checks for a larger version and returns that instead.