Add extraction logic to mitele for videos not based in ooyala #25827
Conversation
youtube_dl/extractor/mitele.py
Outdated
| content = pre_player.get('content') or {} | ||
| info = content.get('info') or {} | ||
| content = pre_player.get('content', {}) | ||
| info = content.get('info', {}) |
There was a problem hiding this comment.
This is not equivalent, do not touch.
There was a problem hiding this comment.
So sorry, and I must confess that it's the second time I make the same mistake in my life 🤦♂️
youtube_dl/extractor/mitele.py
Outdated
| cerbero_data = { | ||
| 'bbx': caronte['bbx'], | ||
| 'gbx': gbx['gbx'] | ||
| } | ||
| headers = { | ||
| 'Content-Type': 'application/json;charset=UTF-8', | ||
| 'Origin': 'https://www.mitele.es' | ||
| } |
There was a problem hiding this comment.
I made like this for improving readability from my side as I read in the documentation, but I understand your point of view.
youtube_dl/extractor/mitele.py
Outdated
| stream = '%s?%s' % (caronte['dls'][0]['stream'], | ||
| cerbero['tokens']['1']['cdn']) |
There was a problem hiding this comment.
Do not encode query into URL but pass via appropriate _extract_m3u8_formats parameter.
There was a problem hiding this comment.
I've passed it through query parameter, but the result isn't very readable from my point of view. Anyway, if this is the way to go, just go ahead and if you expected something different just tell me.
|
Force pushed an update in my branch, let's see if this is the definitive! |
|
thanks a lot it works |
NO, ahora son de pago. |
Pagando, esta protegido para que sólo alguien que pague pueda bajarlos. Pero si pagas puedes conseguir los m3u8 |
|
Any news on this? |
dstftw
force-pushed
the
master
branch
2 times, most recently
from
5e26784 to
da2069f
Compare
|
stoped working? |
|
@DjMoren can you make the requested change in order to merge this PR? Thanks. |
|
is broken again dont merge |
|
Can you @felisucoibi or @bdovaz be more precise when you comment things? I have checked that tests are passing and done a manual test right now for Mi casa es la tuya T09x98 and everything was correct. If you find an error, please detail it, and if anyone have time to solve it will do. I only PRed this because previously it wasn't working when I needed it, but I'm not the main supporter, you should understand it. PS: I'm not going to add support for payed videos because I'm not going to pay for an account here. |
|
I have simply said if you can merge this PR, nothing more. I haven't tried it because I don't know how to test something that is not published, I only use the Windows version. |
|
No, you said |
I meant because of this on the bottom: Changes requested |
|
Oh damm, I didn't search and ended redoing it myself from scratch on my branch -> #26757 |
|
New urls not wroking. 2020-10-23 Cuarto Milenio - /programas-tv/cuarto-milenio/temporada-15/programa-623-40_1008608575015/player/ |
|
Is possible to make this work with session videos that needs login and a cookie? |
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Mitele has done changes, and some of the videos doesn't work with the extractor logic that was present (I'm not sure if it really works with anyone). That said, I've added new logic for videos not based in ooyala. This really fixes this issue. The account-needed tag added to that issue is not correct, it's only needed if you try to enter from outside Spain or if the video belongs to mitele PLUS (premium videos), and the videos posted in that issue can be downloaded correctly with posted fix without any account. That not happens with the videos posted in another issue, where the first is unavailable and the other belongs to mitele PLUS, that is not supported for the moment by the extractor logic (I don't have an account).