Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: revive CI #6

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Dec 21, 2022

I'm limiting this PR to Python 3.8 and 3.9 as more recent versions have never been tested yet and I've seen some problems with them in my first attempt.

I'm also migrating the build backend from poetry to setuptools because well...

  • I don't know poetry
  • no other yt-project package uses it, so we don't have the expertise to maintain that

@neutrinoceros neutrinoceros changed the title TST: boostrap CI TST: bootstrap CI Dec 21, 2022
@neutrinoceros neutrinoceros changed the title TST: bootstrap CI TST: revive CI Dec 21, 2022
@neutrinoceros neutrinoceros marked this pull request as ready for review December 21, 2022 11:53
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but the only lingering question I have is whether or not we need to specify a compiler at the minimum level. Looks like with the tests passing we don't, though.

- ubuntu-latest
python-version:
- '3.8'
- '3.9'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holding off on 3.10 and 3.11?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried both and got some runtime errors with pyximport. I'll work on that in a follow up PR

@neutrinoceros neutrinoceros merged commit 2cdbb95 into yt-project:master Dec 21, 2022
@neutrinoceros neutrinoceros deleted the bootstrap_ci branch December 21, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants