Skip to content

Commit

Permalink
[jsinterp] Fix division (#7279)
Browse files Browse the repository at this point in the history
* Fixes nsig decryption for Youtube JS player `8c7583ff`

Authored by: bashonly
  • Loading branch information
bashonly authored Jun 10, 2023
1 parent 4f7b11c commit b4a252f
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
7 changes: 7 additions & 0 deletions test/test_jsinterp.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ def test_basic(self):
def test_calc(self):
self._test('function f(a){return 2*a+1;}', 7, args=[3])

def test_div(self):
jsi = JSInterpreter('function f(a, b){return a / b;}')
self.assertTrue(math.isnan(jsi.call_function('f', 0, 0)))
self.assertTrue(math.isnan(jsi.call_function('f', JS_Undefined, 1)))
self.assertTrue(math.isinf(jsi.call_function('f', 2, 0)))
self.assertEqual(jsi.call_function('f', 0, 3), 0)

def test_empty_return(self):
self._test('function f(){return; y()}', None)

Expand Down
4 changes: 4 additions & 0 deletions test/test_youtube_signature.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,10 @@
'https://www.youtube.com/s/player/cfa9e7cb/player_ias.vflset/en_US/base.js',
'aCi3iElgd2kq0bxVbQ', 'QX1y8jGb2IbZ0w',
),
(
'https://www.youtube.com/s/player/8c7583ff/player_ias.vflset/en_US/base.js',
'1wWCVpRR96eAmMI87L', 'KSkWAVv1ZQxC3A',
),
]


Expand Down
2 changes: 1 addition & 1 deletion yt_dlp/jsinterp.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def wrapped(a, b):


def _js_div(a, b):
if JS_Undefined in (a, b) or not (a and b):
if JS_Undefined in (a, b) or not (a or b):
return float('nan')
return (a or 0) / b if b else float('inf')

Expand Down

0 comments on commit b4a252f

Please sign in to comment.