add docker container #178
Open
add docker container #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysugimoto
reviewed
May 7, 2019
Owner
ysugimoto
left a comment
ysugimoto
left a comment
There was a problem hiding this comment.
I'm not sure what purpose for docker container.
Could you tell me why do you want to use docker?
| ARG AWS_CLI_VERSION=1.16.86 | ||
|
|
||
| RUN apk --update add python py-pip bash make imagemagick && \ | ||
| pip --no-cache-dir install awscli==$AWS_CLI_VERSION |
Owner
There was a problem hiding this comment.
Why do you use python ?
This package uses claudia.js for deploying lambda function, and all dependencies will be installed via npm package manager, so I think it wouldn't pollute your environment.
Collaborator
|
heh, so to avoid hassle of installing dependencies you're proposing hassle of installing Docker? :D I get your point, though it would be nice to move description further down and present as an alternative approach, plus it would be nice to add some use case examples for people less experienced with Docker. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids some hassle of installing dependencies.
I had success deploying and updating the lambda to aws with this container.