fix(alertrules): avoid making alert rules readonly in UI when updated #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything, that can be done to get a review (and merge) for this PR? |
|
Keen on this one too, any updates on possible merge? |
|
@jarmd Hi. Can I use your solution to reborn this repo? |
|
Hi
Yes feel free to use what ever I suggested :)
Currently we are not using this at the moment since it did not support Grafana 3.x.x !
I’m not the owner by the way
Sendt fra Outlook til iOS<https://aka.ms/o0ukef>
Classification: Restricted
…________________________________
Fra: Danila Epishev ***@***.***>
Sendt: Saturday, February 1, 2025 1:34:46 PM
Til: ysde/grafana-backup-tool ***@***.***>
Cc: Jan P. Madsen ***@***.***>; Mention ***@***.***>
Emne: Re: [ysde/grafana-backup-tool] fix(alertrules): avoid making alert rules readonly in UI when updated (PR #263)
EXTERNAL EMAIL: Be careful with links/attachments
@jarmd<https://github.com/jarmd> Hi. Can I use your solution to reborn this repo?
I want to contribute, but looks like repository is dead
—
Reply to this email directly, view it on GitHub<#263 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BDYOPXHZKG6LTULI4MFGCXL2NU4XNAVCNFSM6AAAAABEBQ52ESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRZGEZDIMBQGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
Vestas will as part of your communication, interaction and business relationship with us collect and process personal data about you.
You can read more about Vestas’ collection and processing of your personal data and your rights as a data subject in our Privacy Policy<https://www.vestas.com/en/about/profile/privacy-policy>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix, so existent alert rule will not move into "Provisioned" state when updated by a restore.
This has been tested on our staging and production environment, by using the following forked version:
https://github.com/vestas-oss/grafana-backup-tool
1 thing to add is that IF someone has run the restore before this fix, the alarts will keep staying in provisioning mode, and the only way to correct this is to delete all alert rules using the grafana API: