Skip to content

2 extended id canmessage field actually sets remote request #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

2 extended id canmessage field actually sets remote request #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cba450a
fix can_id bit shift
ys-oh Sep 2, 2024
2de06b0
modified README.md
ys-oh Sep 2, 2024
7468238
update fetch version
ys-oh Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,25 +17,30 @@ Target Device :

in [user manual](https://www.peak-system.com/produktcd/Pdf/English/PCAN-Ethernet-Gateway-FD-DR_UserMan_eng.pdf), custom gateway protocol is presented.

in Route Configuration Page, add Routing IP Addresses both side(CAN->Ethernet, Ethernet->CAN)
### Handshake Off
you must **disable handshake** for custom protocol integration.

- enter "Expert Mode" in admin page
- turn Handshake Checkbox off

### Router Configuration
in Route Configuration Page, add Routing IP Addresses both side
- CAN->Ethernet
- Ethernet->CAN

<br>

## Install Plugin Package

install from PyPI
```shell

# install from PyPI
$ pip3 install pcan-gatewaybus
```

or

# local installation
local installation
```shell
$ git clone https://github.com/ys-oh/python-can-gatewaybus
$ cd python-can-gatewaybus
$ pip3 install .

```


Expand Down
2 changes: 1 addition & 1 deletion gateway/gateway.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def get_binary(self):
def __get_canid(self):
arbitration_id = self.can_id & 0x3FFFFFFF
rtr = (1 << 29) if self.remote and not self.fd else 0
extid = (2 << 29) if self.extend_id else 0
extid = (1 << 30) if self.extend_id else 0
return arbitration_id | rtr | extid

def __get_channel_idx(self):
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

setuptools.setup(
name="pcan-gatewaybus",
version="0.0.2",
version="0.0.3",
author="yunsik oh",
author_email="oyster90@naver.com",
description="pcan gatewaybus backend for \"python-can\"",
Expand Down