Include version.h in repository, remove from .gitignore #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many code checking editors, marking the common.h as erroneous, as version.h is missing. This can lead to confusion. Change in Makefile.in with fake empty dependency ensures, that version.h is recreated at every "make" Another change in make clean, makes sure, that at this point a stub version.h is generated. version.h removed from .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many code checking editors, marking the common.h as erroneous, as version.h is missing.
This can lead to confusion. Change in Makefile.in
make cleangenerates a stub of version.h with no contentversion.h removed from .gitignore
With this change the code will look pretty and without any error, after fresh clone and after each
make clean.It was really driving my nuts, why my editor marked the code sometimes as buggy and sometimes not.