Improve robustness against malformed packets #53

src/common/alccodec/alcraptor.rs

@@ -70,6 +70,10 @@ impl AlcCodec for AlcRaptor {
         let n = fti[12];
         let al = fti[13];
 
+        if symbol_size == 0 {
+            return Err(FluteError::new("Symbol size is null"));
+        }
+
         if z == 0 {
             return Err(FluteError::new("Z is null"));
         }

src/common/alccodec/alcraptorq.rs

@@ -78,6 +78,10 @@ impl AlcCodec for AlcRaptorQ {
             al
         );
 
+        if symbol_size == 0 {
+            return Err(FluteError::new("Symbol size is null"));
+        }
+
         if z == 0 {
             return Err(FluteError::new("Z is null"));
         }

src/receiver/blockdecoder.rs

@@ -110,6 +110,12 @@ impl BlockDecoder {
             return;
         }
 
+        debug_assert!(self.decoder.is_some());
+        if self.decoder.is_none() {
+            log::error!("Decoder has been deallocated");
+            return;
+        }
+
         let payload = &pkt.data[pkt.data_payload_offset..];
         let decoder = self.decoder.as_mut().unwrap();
         decoder.push_symbol(payload, payload_id.esi);

src/sender/block.rs

@@ -25,6 +25,10 @@ impl Block {
         block_length: u64,
         oti: &Oti,
     ) -> Result<Box<Block>> {
+        if oti.encoding_symbol_length == 0 {
+            return Err(FluteError::new("Encoding symbol length is null"));
+        }
+
         let nb_source_symbols: usize =
             num_integer::div_ceil(buffer.len(), oti.encoding_symbol_length as usize);
         log::debug!(