fix(Calendar): fix timezone #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjiahan
reviewed
Jan 11, 2022
| @@ -6,7 +6,6 @@ function getMonths(minDate, maxDate) { | |||
| var cursor = getDate(minDate); | |||
|
|
|||
| cursor.setDate(1); | |||
| cursor.setMinutes(cursor.getMinutes() - cursor.getTimezoneOffset()); | |||
There was a problem hiding this comment.
原先这句是为了处理单测github action的timezone和中国时区不对导致不通过的问题，但是发现会导致 #4718 这样的问题。
2022-1-1实际是 周六 ，但是由于这里 cursor.getTimezoneOffset() 在中国区是 -480，实际变成了 cursor.setMinutes(cursor.getMinutes() + 480); 导致增加了8小时到了 周日
单测的时区问题，更合理的做法应该是通过 Set Timezone Action 设置正确的时区
所以这个错误的写法应该是要被修正的
There was a problem hiding this comment.
关于时区导致 Calendar 单测不通过的问题
原因是因为在 <month /> 上设置了 data-date 属性，这个属性是一个具体的时间戳
本地 yarn test 的时候是基于中国区的时间，而跑 Github Action 的时候应该是基于国外的时区，这导致每次这个具体的时间戳都会对不上
所以只能在跑 Github Action 的时候锁定中国区
这样设置后，国外开发者PR可能会遇到时区问题，但是vant-weapp应该极少有国外开发者PR
其实理论上来说任何时区都应该是正常的才对，但是小程序只能通过 data-date 这样的方式传值，就有点无解
还有用来测试的PR 这个分支我尝试了把 <month /> 写死也会出现禁用日期和快照不一致的情况(大致就是国外时间和国内不一样，所以disabled的日期也会不一样)
关于vant单测
vant的单测没有设置时区，但是单测还是能跑过。看了下快照上没有出现像 data-date这样写死一个时间戳的情况
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4718