Skip to content

Conversation

@prichhazed
Copy link

Content as per this document.

@prichhazed prichhazed marked this pull request as ready for review August 23, 2021 12:32
---

# Try in pytest
{:.no_toc}
Copy link
Contributor

@dinamlev dinamlev Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's going on with the table of contents here and elsewhere

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -1,5 +1,5 @@
---
parent: CI and CLI Documentation
parent: CI and CLI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to sync to the latest changes in the repo to pick up the CI/CLInav updates, etc. before sending this out for review.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@dinamlev dinamlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Priyanshu,

I've left some comments on your change. I think it would be best to work from the docs.yourbase.io repository with the new content so that we can be looking at a preview of the site at the same time. Would you mind addressing these requests in a new PR for that repository?

Thank you!

- Ruby Test Acceleration - Coming soon! Contact us at [hi@yourbase.io](mailto:hi@yourbase.io) if you
want to join the private beta.
# YourBase
Some text talking about test acceleration & links to CI CLI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are hiding the CLI info, this section seems extraneous - thoughts?

Copy link
Author

@prichhazed prichhazed Aug 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I've removed this page altogether. And set the "Home" page to the introduction to Test Acceleraiton.
Also, I've moved all CLI pages under the cli folder, and also marked them to be excluded from the navigation.

Let me know your thoughts.

@@ -1 +1 @@
docs.yourbase.io No newline at end of file
prichhazed.github.io No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be changed in prod

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

baseurl: "" # the subpath of your site, e.g. /blog
url: https://docs.yourbase.io
domain: docs.yourbase.io
url: https://prichhazed.github.io/yb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be changed in prod

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

url: https://docs.yourbase.io
domain: docs.yourbase.io
url: https://prichhazed.github.io/yb
domain: prichhazed.github.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be changed in prod

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@@ -1,15 +0,0 @@
<!--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually keep/add redirect pages for SEO purposes - same for other deleted files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.


---

## Will it provide benefits at your scale?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX note: better for second person words to be first person - substitute "your" with "my" in the question

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


---

## Is it compatible with your tech-stack and infrastructure?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX note: better for second person words to be first person - substitute "your" with "my" in the question

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

</details>

## YOURBASE_ACCEPT_TOS
`Type`: `bool-ish (0, false, off, 1, true, on)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting for the type + default does not look right - currently appears all on same line - please could you address for all options?

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


When on, YourBase Test Acceleration will use a slower tracing algorithm that is less prone to conflicts with other packages than the default.

We recommend reaching out to support@yourbase.io if you are encountering this scenario, and only enabling this if you experience issues with the default algorithm.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you add mailto links wherever email addresses appear in the PR, e.g. for support@yourbase.io, hi@yourbase.io? Thank you!

example: hi@yourbase.io

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


## Conflict with plugin pytest-xdist

The YourBase Test Acceleration Test Selection and pytest-xdist [link] plugins have similar goals, reducing the overall test execution time of tests, but take different approaches to solving the problem. As such, there are conflicts when both plugins are enabled. When using the YourBase Test Acceleration Test Selection plugin, please uninstall pytest-xdist or execute pytest-xdist with `NUMCPUS=0`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a link

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants