Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support of older systems, with GCC 4.9 and cmake 3.6.2 (Debian 8) #166

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

braindigitalis
Copy link

sleepy-discord wouldn't build on my older Debian system. With some time to do so, and not having the ability to simply upgrade the server, I've built a small patch-set that fixes the issues. Please merge in at your leisure if you find this useful.

The three commits are as follows:

  1. One-line change to sleepy_discord/CMakeLists.txt to allow older cmake 3.6 to find and use C++14
  2. Small change to sleepy_discord/client.cpp in rate limiting code, changes single use of std::get_time() to strptime(), which does the same thing but is the C style way, better backwards compatibility.
  3. Some small and simple changes to json.c to stop it complaining about declarations of variables inside for loop keywords.

@braindigitalis braindigitalis changed the title Three commits for support of older systems, with GCC 4.9 and cmake 3.6.2 Adding support of older systems, with GCC 4.9 and cmake 3.6.2 (Debian 8) Oct 23, 2019
@braindigitalis
Copy link
Author

After updating to newer cmake and also moving to develop branch, only the get_time() part of this merge is required there. This cuts down the patch significantly.

@yourWaifu
Copy link
Owner

the json.c stuff has been removed and right now I'm merging develop branch, so there's going to be merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants