fix ping schedule issue #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vu-luong
reviewed
Sep 7, 2021
| EzyConnectionFailureEvent mevent = (EzyConnectionFailureEvent)event; | ||
| Map map = new HashMap<>(); | ||
| map.put("reason", mevent.getReason().toString()); | ||
| map.put("reason", mevent.getReason().getId()); |
There was a problem hiding this comment.
Sao ở dòng này là map.put("reason", mevent.getReason().getId());. Mà ở dòng 61 lại là: map.put("reason", mevent.getReason());
There was a problem hiding this comment.
vì reason ở disconnection là int, còn của connection failure là enum em ạ
| config.ping.pingPeriod = 1000; | ||
| config.reconnect.maxReconnectCount = 10; | ||
| config.reconnect.reconnectPeriod = 1000; | ||
| // config.enableDebug = true; |
There was a problem hiding this comment.
Lúc user muốn enable debug là phải uncomment chỗ này hả anh?
vu-luong
reviewed
Sep 7, 2021
flutter không có em ạ, vì flutter gọi xuống các sdk c++ với android, 2 sdk này đã có phần check đó rồi em ạ |
vu-luong
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.