add support for glob syntax, address issue 50 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See documentation for Glob class in Glob.cs
Note that this is fully backwards-compatible
with existing non-fuzzy matching, so it is unnecessary
to add a new setting.
Moved some helper functions to MiscUtils.cs
Rearranged code in NppNavigateTo.cs in an order that
more closely parallels the order in which it is first referenced.
Also started to add code for a background worker.
I may eventually consider offloading some work to a background worker
but currently it doesn't seem super necessary.
|
@molsonkiko It looks like after search file list keeps filtered files instead of showing all files. Please could you check it in version 2.6.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See documentation for Glob class in Glob.cs. Would implement #50.
Note that this is fully backwards-compatible with existing non-fuzzy matching, so it is unnecessary to add a new setting.
Moved some helper functions to MiscUtils.cs (needed for re-use in GlobTester.cs and TestRunner.cs)
Rearranged code in NppNavigateTo.cs in an order that more closely parallels the order in which it is first referenced. Most of the diff in that file is just moving stuff around, and most of the remaining diff is due to the introduction of glob syntax.
Also started to add code for a background worker; it's all commented out now.
I may eventually consider offloading some work to a background worker but currently it doesn't seem super necessary. It is only helpful when dealing with many thousands of files (based on testing with roughly 59k files), but it could be critical in that case for preventing NavigateTo from locking up Notepad++.
This does not appear to break any existing functionality, although I've never really understood how the fuzzy matching is supposed to work so I wouldn't necessarily know if the fuzzy matching wasn't working quite as intended.