Fix directory search bugs from last PR #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix bug (introduced by previous commit)
where searching the top directory only led to
an uncaught error.
2. Do not trigger a directory search when opening
a file in the same directory as the previously open file.
3. Require that the button to allow subdirectory search
can only be checked if and only if
the button to allow top directory search is also checked.
4. Always trigger a directory refresh when directory search
when settings are changed.
previous commit forgot to include delay
also had to cast 10_000_00 to long because
with large delays we were getting int overflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where searching the top directory only led to
an uncaught error.
a file in the same directory as the previously open file.
can only be checked if and only if
the button to allow top directory search is also checked.
when settings are changed.