Add SOCKS5 proxy support

[pointydev]

Is your feature request related to a problem? Please describe.
As a Mullvad user, I can set SOCKS5 proxy addresses (e.g. ee-tll-wg-socks5-001.relays.mullvad.net:1080 for Estonia) to divert specified traffic to a different output server while connected to any of their WireGuard servers. I can't use these addresses with TTV LOL PRO as it only supports HTTP proxies.

Describe the solution you'd like
The ability to use SOCKS5 proxies with TTV LOL PRO natively.

Describe alternatives you've considered
Using socks-to-http-proxy in order to convert the proxy locally, however this is rather janky as it requires restarts on network condition changes.

Additional context
The list of proxy addresses for available to Mullvad users can be seen here after filtering to WireGuard servers only, then expanding server details:

Thanks,
pointy

[zGato]

That is just a local address, you must be connected to Mullvad already, as you said. The extension isn't VPN-friendly and I personally wouldn't add any sort of SOCKS/HTTPS proxy support as it will cause confusion to most users that don't even know what an HTTP proxy is.

Using a VPN on top of the extension is just pointless, and will cause issues. We do not support, nor recommend it.

There's also no easy way to differentiate a proxy by its type. SOCKS's default port is 1080, and I don't know of any proxy provider that will even give you that port by default.

[pointydev]

I haven't observed any issues with running the extension behind a VPN, using the program mentioned above to translate the SOCKS proxy to a HTTP one, with the built-in public proxy as a fallback for when my translator fails.

Addresses could simply be prefixed with socks5:// so as not to confuse regular users, with all other addresses being treated as HTTP proxies.

[zGato]

It does cause issues with authentication or the proxy outright not working at all. Observed that already from NordVPN users. Even if they're not connected but just have the app in the background.
"VPN" extensions also cause similar issues.

We use the following syntax for authentication: user:password@proxy. That would break it.

[pointydev]

Regardless of the VPN issues you have observed, parsing the protocol would be the only addition to your syntax, as socks5://user:password@proxy:port is a fairly standard format.

[zGato]

Regardless of how it's implemented, we do not support, nor recommend using a VPN on top of TTV LOL PRO.

I cannot find any use case for SOCKS/HTTPS support. Mullvad is the only one I know that provides SOCKS proxies, but you must be connected to the Wireguard tunnel, which is kinda xD. NordVPN only supports those in certain locations (which none of them are ad-free), Proton explicitly doesn't. Windscribe creates a local HTTP/SOCKS5 tunnel, which is kinda the same as the app you mentioned. Surfshark explicitly doesn't.

Some of these might support HTTPS, but I don't really want people being tricked into installing certificates into their PCs and having all of their data MITMd. And even if they support it, it's quite tricky to get the info and authentication details.

[younesaassila]

Given how many times this topic gets suggested, I think it's worth to look at an experimental implementation, especially since there's already an open PR about it

Edit: If there is an implementation added to the extension, there would likely also be some kind of informational/warning message that HTTP proxies are preferred. Maybe put the feature behind a toggle

[pointydev]

Thanks for pointing out #332, seems I overlooked it while searching for existing discussions. I agree with the toggle option, either per proxy or as a global switch that enables other protocols to be used, or a combination of the two (similar to uBO advanced switch?).

[younesaassila]

Working on it :)