test: hooks integration test

[tony84727]

Add hooks integration test

See #361

Signed-off-by: Tony Duan tony84727@gmail.com

[utam0k]

@tony84727 Thanks for your PR. Great! I left a comment, please check.

[utam0k]

Why do we need to call twice per-hook?

[tony84727]

It's ported from here:
https://github.com/opencontainers/runtime-tools/blob/0105384f68e16803891d0a17d9067b1def6a2778/validation/hooks/hooks.go#L32-L67
I was having the same question. I guess calling twice is to ensure the implementation actually executes hooks in the given order. (hook 1 then hook 2 in sequence)

[codecov-commenter]

Codecov Report

Merging #959 (859c217) into main (99fe4f8) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
+ Coverage   69.12%   69.23%   +0.11%     
==========================================
  Files         118      118              
  Lines       12460    12440      -20     
==========================================
  Hits         8613     8613              
+ Misses       3847     3827      -20     

[tony84727]

Test failed. I will look into this. Maybe it's a race condition of hooks writing logs?

[utam0k]

@tony84727 This indicates that the runc did not pass the test, not youki. We run integration tests on runc to verify the integration tests themselves.

# Start group hooks
1 / 1 : hooks : not ok
	error : hooks must be called in the listed order

[tony84727]

@tony84727 This indicates that the runc did not pass the test, not youki. We run integration tests on runc to verify the integration tests themselves.

# Start group hooks
1 / 1 : hooks : not ok
	error : hooks must be called in the listed order

👌 I've made runc pass hooks test on my machine. Somehow, for hooks to write logs, we need to specify absolute path instead of simply output. I'm not sure why.