-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cargo-llvm-cov and use rust 1.60.0 for coverage #898
Conversation
86700a4
to
39399ef
Compare
.github/workflows/main.yml
Outdated
@@ -77,18 +77,16 @@ jobs: | |||
- name: Toolchain setup | |||
uses: actions-rs/toolchain@v1 | |||
with: | |||
toolchain: nightly-2022-01-14 | |||
toolchain: nightly-2022-05-06 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally tried to use 1.60.0 here, but ibcontainer enables the unstable feature when coverage is enabled, so I reverted to nightly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After more looking into it, I found that the actual use of no_coverage is only here, and it is no-op (because applied to use
statement).
So I believe we can safely remove the use of the unstable feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the use of the unstable feature and changed to use rust 1.60.0: a7e800f
5c9d5e6
to
a7e800f
Compare
Hey @taiki-e Thanks for your contribution! Can I ask you to remove this line in .github/workflows/main.yml? ...
- name: Run Test Coverage for youki
run: |
cd ./crates # Please remove this line, as now we need to run this from project root instead of crates/
... Thanks :) |
Unrelated Note (Self) : Also, test_guid_mapping was running for more than 15 mins, so it was cancelled in Rust 1.59, although ran fine in Rust 1.60. Might be just flaking issue, but needs a look at it. |
@YJDoc2 Thanks for the review! I applied your suggestion. |
Signed-off-by: Taiki Endo <te316e89@gmail.com>
Signed-off-by: Taiki Endo <te316e89@gmail.com>
Signed-off-by: Taiki Endo <te316e89@gmail.com>
Signed-off-by: Taiki Endo <te316e89@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you @taiki-e
This should be enough to address #316 (comment).